Add resource for kibana synthetics monitors: http and tcp#699
Merged
biscout42 merged 80 commits intoelastic:mainfrom Aug 20, 2024
Merged
Add resource for kibana synthetics monitors: http and tcp#699biscout42 merged 80 commits intoelastic:mainfrom
biscout42 merged 80 commits intoelastic:mainfrom
Conversation
biscout42
commented
Aug 9, 2024
tobio
reviewed
Aug 18, 2024
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
LGTM, we're going to need to deal with the state transition in the private_location resource unfortunately.
Member
|
We'll also need a CHANGELOG entry too |
…reven deletion of same private location across tests.
Contributor
Author
|
@tobio , could you ack it again 🙏 ? I have split resources in monitor test to prevent cross-resource deletion. |
Contributor
Author
|
FYI: I enabled auto-merge. |
tobio
approved these changes
Aug 20, 2024
tobio
added a commit
that referenced
this pull request
Aug 26, 2024
* origin/main: Add support for the `alert_delay` param in the Create Rule API (#715) chore: prepare release v0.11.6 (#716) Validate that mappings are a JSON object, not just valid json (#719) fix: move all resources in one namespace for tcp monitor acc tests (#717) Bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.1 in /tools (#714) Bump github.com/docker/docker in /tools (#718) Bump github.com/goreleaser/goreleaser from 1.26.1 to 1.26.2 in /tools (#642) Bump github.com/hashicorp/terraform-plugin-framework (#705) Add kibana synthetics http and tcp monitor resources (#699) Kibana spaces data source (#682) Use ephemeral github token for build. (#712) chore: 8.15.0 is here - lets try it out (#708) Update changelog for 0.11.5 Bump version for 0.11.5 (#706) Bugfix SLO API: Update type for `group_by` to accept either string or array-of-strings (#701) Support `restriction` in `elasticstack_elasticsearch_security_api_key` (#577) chore: follow-up CR changes for synthetics private location resource (#697)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #610
TODOs
tfModelV0and unit test for API <-> tf model conversiontcpin kibana API client